Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GTFS.Routes subscribed to :gtfs_producer #362

Merged
merged 1 commit into from
Oct 21, 2024
Merged

GTFS.Routes subscribed to :gtfs_producer #362

merged 1 commit into from
Oct 21, 2024

Conversation

KaylaBrady
Copy link
Contributor

@KaylaBrady KaylaBrady commented Oct 18, 2024 •
edited
Loading

Summary of changes

Asana Ticket: Bus trips with block waivers not marked as cancelled

Ensure the routes table is populated with route records so that bus trips with block waivers are cancelled.

Debugging bus trips that had skipped stops but weren't marked as cancelled, @boringcactus observed that it is expected for them to be marked as cancelled here. It seemed the bus_block_waiver? check might be failing. I observed no logs in Splunk from Concentrate.GTFS.Routes as expected here, and figured it was missing from the supervisor.

Testing

  • Confirmed Splunk log that GTFS.Routes table is updated as expected
    7deb6bd8b11a 2024-10-21T14:39:00.577 [info] Elixir.Concentrate.GTFS.Routes: updated with 382 records

Looking at a bus trip with a block waiver in prod marked as skipped:

{
      "attributes": {
        "arrival_time": null,
        "arrival_uncertainty": null,
        "departure_time": null,
        "departure_uncertainty": null,
        "direction_id": 1,
        "last_trip": false,
        "revenue": "REVENUE",
        "schedule_relationship": "SKIPPED",
        "status": null,
        "stop_sequence": 1,
        "update_type": null
      },
      "id": "prediction-64463790-110-1-1",
      ...

Same bus trip in dev-blue with this change applied:

    {
      "attributes": {
        "arrival_time": null,
        "arrival_uncertainty": null,
        "departure_time": null,
        "departure_uncertainty": null,
        "direction_id": 1,
        "last_trip": false,
        "revenue": "REVENUE",
        "schedule_relationship": "CANCELLED",
        "status": null,
        "stop_sequence": 1,
        "update_type": null
      },
      "id": "prediction-64463790-110-1-1",
      ...

@KaylaBrady KaylaBrady marked this pull request as ready for review October 18, 2024 18:51
@Whoops Whoops self-requested a review October 21, 2024 14:36
@Whoops Whoops merged commit 1321df2 into master Oct 21, 2024
40 checks passed
@Whoops Whoops deleted the kb-routes-supervisor branch October 21, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Whoops Whoops Whoops approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KaylaBrady @Whoops